automeris-io / WebPlotDigitizer

Computer vision assisted tool to extract numerical data from plot images.
https://automeris.io
GNU Affero General Public License v3.0
2.6k stars 358 forks source link

Data not being updated (Blob Detector) #39

Closed nordange closed 9 years ago

nordange commented 9 years ago

There seems to be a problem with the combination of automatic and manual mode. After the automatic mode has applied and I switch to manual mode, I can adjust the points. However, once I try to add points, the red dots are drawn correctly but the points are somehow not registered. Any adjustment of previous points is not registered at all. The point data as shown in "View data" seems frozen. Moving points around or adding or deleting point does not seem to have an effect on the data.

ankitrohatgi commented 9 years ago

I switch from automatic to manual many times, but have not seen this issue, but it is possible that I have missed some scenario. I will need some more information from you to investigate further:

1) Which automatic extraction algorithm did you use before switching to manual mode? 2) Which browser and operating system were you using? 3) Did you add multiple datasets from the 'Manage Datasets'?

Thank you! Ankit

ankitrohatgi commented 9 years ago

I went ahead and tried out all the algos. I do see this issue with the blob detector algorithm, but none of the others. Is that the one you were working with?

nordange commented 9 years ago
  1. Blob - it definitely seems to be related to this extraction algorithm
  2. Chrome, Windows 7
  3. No.
ankitrohatgi commented 9 years ago

Thank you, I will look into it.

nordange commented 9 years ago

Great, thanks!

ahcyip commented 9 years ago

I had the same problem when using blob detector and then manually adjusting.

ankitrohatgi commented 9 years ago

Simply adjusting the positions should work, but if you are deleting and adding points, then there's no way for the program to calculate area and moments associated with that point as they come from the extraction algorithm. I can fix this part so that it lets you add point with empty values for area and moment.

I am curious about the types of images you are using this for. I added this because I needed to measure some particle sizes in an image from a multiphase fluid flow experiment. I think very few people use this algorithm so if you can share a few examples, then it would help me design this part a bit better.

Thanks, Ankit

ahcyip commented 9 years ago

your responsiveness is much appreciated! I was trying to get the red points. Unfortunately none of the algos worked well for this type of shape/point. rangel2014

ankitrohatgi commented 9 years ago

The symbols between 1980 to 1990 are very difficult to distinguish even for a human. In this case, you will have to resort to using the manual mode completely.

The blob detection algorithm is more useful for doing area and shape measurements. I will fix the fact that using this algorithm blocks manual editing of data.

Thanks!

ahcyip commented 9 years ago

Yes I ended up using manual mode completely anyway but wanted a head start on point placement. But is it true that none of your algorithms can handle "X"-shaped points on X-Y plots?

ankitrohatgi commented 9 years ago

It is not dependent on shape. For your case, if you want the 'X' points between 1995 and 2005, then you can even use the default "Averaging Window" algorithm. You will have to raise the delta_x and delta_y values to about 25. For the other overlapping points, it will be hard for the algorithm to calculate the correct centers of the overlapping "X"s.

ahcyip commented 9 years ago

makes sense. I guess overlapping points are just quite tricky. thanks.

nordange commented 9 years ago

I use the algorithm to catch the centre of circles shown below.

image

ankitrohatgi commented 9 years ago

@kartham For your image, you can also use the default averaging window for the points on the right. You will have to do a manual adjustment after this (see image):

wpd

ankitrohatgi commented 9 years ago

I have corrected the issue with the blob detector blocking the manual editing btw - I will be included in the next release. Thank you both for pointing it out :)

ankitrohatgi commented 9 years ago

delta_x and delta_y of 28 work the best actually:

image