Decide if we want to do proxying for Prometheus and pushgateway

[hatchan]

Currently we are running prometheus and pushgateway on a specific port, and we are also forwarding the content using the listen address of am + /prometheus. This requires us to specify the web-address as a config to either components. The downside is that the origin then uses the new path in the prometheus web server. Which can be confusing for a user since they need to forward their metrics to localhost:9091/pushgateway/metrics which can be confusing.

Pro's of proxying:

• We are able to swap out the implementation, but explorer would just rely on the proxied endpoint
• Have a single port for all components
• No CORS issues when any component is running on the same port as explorer

Con's:

• Rewrites the path even for the locally running component.
• Need to explain that the user has to use a different path for pushing metrics.

[brettimus]

The Pros seem compelling.

Could you elaborate on the con of rewriting the path? (What makes that a con specifically?)

And for the "/pushgateway/metrics" issue: Is there a world where we could map all POST requests to /metrics to the pushgateway? Or is that messy to implement?

[hatchan]

Could you elaborate on the con of rewriting the path? (What makes that a con specifically?)

Might be more of familiarity of current users. If let's say you have some other tools that need to interact with Prometheus, but you expect prometheus to run at http://localhost:9090/ then it won't work. Since then actual endpoint is http://localhost:9090/prometheus/.

And for the "/pushgateway/metrics" issue: Is there a world where we could map all POST requests to /metrics to the pushgateway? Or is that messy to implement?

That is a good idea :+1: . If the pushgateway is enabled, we can indeed proxy those POST calls. See https://github.com/autometrics-dev/am/issues/63