Add slo support - Githubissues

autometrics-dev / autometrics-py

Easily add metrics to your code that actually help you spot and debug issues in production. Built on Prometheus and OpenTelemetry.

https://autometrics.dev

Apache License 2.0

214 stars 7 forks source link

Add slo support #16

Closed flenter closed 1 year ago

flenter commented 1 year ago

This PR also includes:

a refactor for a large portion of the code
updates the workflow to run black & tests during ci
changes the way exceptions are handled: the decorator will now rethrow the exception instead of just returning the error

Closes https://github.com/autometrics-dev/autometrics-py/pull/16

brettimus commented 1 year ago

regarding the examples:

is there a simple way to point them to the code from the repo? (so that they run based off of what is in the repo) i wasn't totally clear on how to run them

or should we prefer that they run based off of what's the most recently published package?

v-aparna commented 1 year ago

regarding the examples:

is there a simple way to point them to the code from the repo? (so that they run based off of what is in the repo) i wasn't totally clear on how to run them

or should we prefer that they run based off of what's the most recently published package?

The current examples do not work with the recently published package, for them to work, a local package can be built and then used (python -m build). However, I feel examples are run better off the published package.