search

autometrics-dev / autometrics-py

Easily add metrics to your code that actually help you spot and debug issues in production. Built on Prometheus and OpenTelemetry.
https://autometrics.dev
Apache License 2.0
214 stars 7 forks source link

allow newer prometheus client versions #71

Closed cristifalcas closed 1 year ago

cristifalcas commented 1 year ago

Any reason to force the version of prometheus client to 0.16?

prometheus-client = "0.16.0"

This blocks us from trying out the module, since we have in our projects 0.17 setup already.

actualwitch commented 1 year ago

Hello @cristifalcas! Thank you for checking out autometrics, we'd love to hear what you think about it! We don't have any specific reason to stay on 0.16, we'll bump it in the next release.

brettimus commented 1 year ago

we're picking this up in https://github.com/autometrics-dev/autometrics-py/pull/72!

brettimus commented 1 year ago

alright! @cristifalcas we just cut a new version of autometrics, 0.8, which should work with 0.17.0 and 0.17.1 of prometheus-client

let us know how it goes trying out

cristifalcas commented 1 year ago

thanks, I'll give it a try