search

automl-classroom / iML-ws21-ex08

0 stars 0 forks source link

Wrong return parameter in the description of compute_loss in counterfactual.py #2

Open felixmeyjr opened 2 years ago

felixmeyjr commented 2 years ago

In the compute_loss(...) the docstring states:

Returns: difference (torch.tensor): The summed square error between output and desired_output.

That is the parameter of compute_output_difference.

maxidl commented 2 years ago

Thank you for reporting, fixed it just now.

felixmeyjr commented 2 years ago

How can we pull the changes in iML-ws21-ex08 to iML-ws21-ex08-TEAMNAME anyway? Upstream branch is origin/master of iML-ws21-ex08-TEAMNAME.

maxidl commented 2 years ago

While it sure doesn't feel like an optimal solution, you can try the solution from here:

git remote add template https://github.com/automl-classroom/iml-ws21-ex08
git fetch --all
git merge --allow-unrelated-histories template/master