pipeline options not being updated properly to fit_pipeline

automl / Auto-PyTorch

Automatic architecture search and hyperparameter optimization for PyTorch

Apache License 2.0

2.37k stars 287 forks source link

pipeline options not being updated properly to fit_pipeline #184

Closed ArlindKadra closed 3 years ago

ArlindKadra commented 3 years ago

Could you please check if pipeline_config is being updated properly? According to my debugging, it was not.

https://github.com/automl/Auto-PyTorch/blob/074a8f466b245e3c3852f28bc777783a8fcd6a1d/autoPyTorch/api/base_task.py#L1265

ArlindKadra commented 3 years ago

I think you have to do from copy import copy

Although, I would suggest deepcopy from the context, since you are doing a weak copy with copy only.

ravinkohli commented 3 years ago

hey Arlind, thanks for pointing this bug. Actually, @franchuterivera has made a new PR #172 where he has fixed this. you can find the fix here. maybe we can rebase the cocktails branch from the refactor_development branch to also have the same implementation once this PR is merged

ravinkohli commented 3 years ago

As the corresponding PR #172 has been merged, I'm closing this issue. If there's still something missing, feel free to reopen