Closed JosuaCarl closed 2 months ago
Replacing _construct_forbidden_equals
with _construct_forbidden_relation
in
https://github.com/automl/ConfigSpace/blob/ce27ba26e1cf27a5b9fe242519cb622327c82420/ConfigSpace/read_and_write/json.py#L678
fixed my issue.
The bug also seemed to affect the read-in of the Runhistory in SMAC3, when using ForbiddenRelations
, this also fixed it for me.
Thanks for the issue and solution!
This has been addressed in #346 which we hope to release next week. I'm not sure when SMAC will udpdate to it as they'll likely want to benchmark that nothing is silently broken. That might take another little bit of time
As mentioned in #352, there still is some work to be done on the documentation side of things for
ForbiddenRelations
. Today I encountered another problem when trying to read in aConfigurationSpace
from a.json
file, created with ConfigSpace.Version: 0.7.1
Error:
Code to reproduce:
Tracing: It seems like the following constructor: https://github.com/automl/ConfigSpace/blob/ce27ba26e1cf27a5b9fe242519cb622327c82420/ConfigSpace/read_and_write/json.py#L705-L721
is never called, which should happen at https://github.com/automl/ConfigSpace/blob/ce27ba26e1cf27a5b9fe242519cb622327c82420/ConfigSpace/read_and_write/json.py#L678
Instead, https://github.com/automl/ConfigSpace/blob/ce27ba26e1cf27a5b9fe242519cb622327c82420/ConfigSpace/read_and_write/json.py#L683-L687 is called, which in turn causes the accession attempt of
'name'
, which is not present in theForbiddenRelations
clause