Bugfix for problematic typecheck when creating Integer

automl / ConfigSpace

Domain specific language for configuration spaces in Python. Useful for hyperparameter optimization and algorithm configuration.

https://automl.github.io/ConfigSpace/

Other

202 stars 93 forks source link

Bugfix for problematic typecheck when creating Integer #361

Closed Ultrahero closed 4 months ago

Ultrahero commented 4 months ago

When creating a UniformIntHyperparameter, the default_value is parsed as an int to the uniformFloatHyperparameter, which causes the type_check in line 62 to fail.

This is obviously a bug. This type conversion should fix the bug.

eddiebergman commented 4 months ago

Hi @Ultrahero ,

Appreciate the PR but in #346 we've fixed a lot of bugs and just waiting for some more review before releasing. I will close this PR as a result but thank you again for the PR!