automl / DACBench

A benchmark library for Dynamic Algorithm Configuration.
https://automl.github.io/DACBench/
Apache License 2.0
28 stars 13 forks source link

SGD Benchmark #104

Closed goktug97 closed 3 years ago

goktug97 commented 3 years ago

In sgd_dev branch there were some changes that modifies dacbench. For example ObservationWrapper. So I created a new branch and removed commits that affect the dacbench.

maximilianreimer commented 3 years ago

Hello, I would like to merge this pull request but there are few tests failing I would like to fix/be fixed before that. I already looked at them and could fix them quickly if you could give me access to the branch. Is this possible? (They are mainly due to missing parts of the implementation of serialization/deserialization methods). Alternatively, I could fix them on a copy of the feature branch in the automl repo. What do you prefer?

Best, Max

goktug97 commented 3 years ago

https://github.com/automl/DACBench/pull/106 I pushed the branch to this repo so you should be able to edit it now. I think this will be much easier.