search

automl / DACBench

A benchmark library for Dynamic Algorithm Configuration.
https://automl.github.io/DACBench/
Apache License 2.0
28 stars 13 forks source link

Feature Request: migrate from gym to gymnasium #130

Closed elliottower closed 1 year ago

elliottower commented 1 year ago

Hi, this repository is currently listed in the gymnasium third party environments but we are cleaning the list up to only include maintained gymnasium-compatible repositories.

Would it be possible for it to be upgraded from gym to gymnasium? Gymnasium is the maintained version of openai gym and is compatible with current RL training libraries (rllib and tianshou have already migrated, and stable-baselines3 will soon).

For information about upgrading and compatibility, see migration guide and gym compatibility. The main difference is the API has switched to returning truncated and terminated, rather than done, in order to give more information and mitigate edge case issues.

TheEimer commented 1 year ago

Thanks for the reminder, we're currently working on the interface upgrade (along with some package upgrades in the dependencies) and this should be up soon.

elliottower commented 1 year ago

Good to hear, thanks! Could you post here when it is switched? Makes sure I don’t miss it and can update the third party repos page with your repo.

TheEimer commented 1 year ago

Sure, I'll keep you updated here

TheEimer commented 1 year ago

The migration is complete now and everything works with gymnasium, so you can update now :D

elliottower commented 1 year ago

The migration is complete now and everything works with gymnasium, so you can update now :D

Great to hear, thanks! Any chance you could bump the version to the newest 028.1? You’re currently using 0.26.3 which has a few bugs which have been fixed since. Sorry to bug you but figure might as well keep things up to date and ensure future compatibility and such.

TheEimer commented 1 year ago

The problem is that ray is in the examples and the RLlib still uses 0.26.3 for now. I relaxed the version, though, so unless examples are specified, 0.28.1 should be used.