search

automl / DEHB

https://automl.github.io/DEHB/
Apache License 2.0
71 stars 16 forks source link

Use of deprecated np.int in dimension type checking #41

Closed Bronzila closed 1 year ago

Bronzila commented 1 year ago

Here the deprecated np.int type of numpy is used, when initalizing DEHB without a configspace object. This is deprecated since numpy v1.20 and should be replaced by either np.int32 or np.int64.

SandboxHead commented 1 year ago

Hey @Bronzila I will make these required changes. Can you assign me this issue?

eddiebergman commented 1 year ago

Will add that the deprecation is mostly when used with np.method(..., dtype=np.int) as this is now made equivalent to np.method(..., dtype=int) and the latter should be preferred. In the case you've shown there, the best way to do instance checking right now is isinstance(x, (int, np.integer)). (Likewise you have np.floating super classes np.float32/64)

Bronzila commented 1 year ago

Hey @Bronzila I will make these required changes. Can you assign me this issue?

@SandboxHead I will do so, thanks. It would be great if you could have a look at our contributing guidelines. Since this is currently just a draft, it is not merged to master yet, however it should still be a good guidance.