Closed KEggensperger closed 7 years ago
This PR is now ready for reviewing @aaronkl @mfeurer
Merging #38 into development will increase coverage by
6.33%
. The diff coverage is69.23%
.
@@ Coverage Diff @@
## development #38 +/- ##
===============================================
+ Coverage 49.59% 55.93% +6.33%
===============================================
Files 25 26 +1
Lines 1238 1314 +76
===============================================
+ Hits 614 735 +121
+ Misses 624 579 -45
Impacted Files | Coverage Δ | |
---|---|---|
hpolib/util/data_manager.py | 72.78% <100%> (+10.2%) |
:arrow_up: |
hpolib/benchmarks/ml/logistic_regression.py | 50% <63.41%> (+50%) |
:arrow_up: |
hpolib/util/rng_helper.py | 86.66% <86.66%> (ø) |
|
hpolib/abstract_benchmark.py | 86.66% <0%> (+2.22%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a68a548...6be3444. Read the comment docs.
This PR adds a crossvalidation version of logistic regression and fixes some issues with the random seed.