search

automl / ParameterImportance

Parameter Importance Analysis Tool
http://www.ml4aad.org/
BSD 3-Clause "New" or "Revised" License
76 stars 19 forks source link

feature array is modified by PCA in forward selection #44

Closed shukon closed 6 years ago

shukon commented 7 years ago

Hi, not sure if intended: in forward_selection the self.scenario.feature_array is directly replaced by the PCA'ed array. Later use of the same scenario is difficult when the reference itself is modified. Personally I'd assume that the original scenario-object is not changed when I pass it to an evaluator. I now perform a deepcopy before passing, but this might be difficult to discover when using the package without being aware of it?

AndreBiedenkapp commented 6 years ago

Thanks. I'll change that!