automl / RoBO

RoBO: a Robust Bayesian Optimization framework
BSD 3-Clause "New" or "Revised" License
480 stars 134 forks source link

code in robo.acquisition_functions.marginalization.py #109

Open cjfcsjt opened 5 years ago

cjfcsjt commented 5 years ago

should we change code line 75 : "estimator.model = None" to _"estimator.costmodel" and change code line 77: _"estimator.model = self.costmodel.models[I]" to _"estimator.cost_model = self.costmodel.models[I]"

and should we delete delete line 33-47?

aaronkl commented 5 years ago

Good catch! Could you send a pull request to change that?