search

automl / RoBO

RoBO: a Robust Bayesian Optimization framework
BSD 3-Clause "New" or "Revised" License
482 stars 133 forks source link

typos in logEI ?! #57

Closed sfalkner closed 7 years ago

sfalkner commented 7 years ago

in the file 'robo/acquisition_functions/log_ei.py' the following two lines look suspicious to me:

81: if np.any(abs(f_min - mu)) == 0: 89: if mu < np.any(f_min):

shouldn't these be

81: if np.any( (f_min - mu)<= 0): 89: if np.any(mu < f_min):

aaronkl commented 7 years ago

fixed