automl / TabPFN

Official implementation of the TabPFN paper (https://arxiv.org/abs/2207.01848) and the tabpfn package.
http://priorlabs.ai
Apache License 2.0
1.22k stars 109 forks source link

check_is_compatible not used in get_model #38

Closed amueller closed 1 year ago

amueller commented 1 year ago

You're assigning check_is_compatible but in get_model but then don't use it.

SamuelGabriel commented 1 year ago

I think we do here, no?https://github.com/automl/TabPFN/blob/889fad7070ded19ac3b247daf47d94b2538695cb/tabpfn/priors/flexible_categorical.py#L209

The idea is to remove datasets which have different subsets of classes in the train and test split.

amueller commented 1 year ago

indeed, you are right, my bad!