search

automl / amltk

A build-it-yourself AutoML Framework
https://automl.github.io/amltk/
BSD 3-Clause "New" or "Revised" License
68 stars 6 forks source link

doc(Trial): Better indication of what to do with the Metric name for report #216

Closed vladislavalerievich closed 10 months ago

vladislavalerievich commented 10 months ago

[UX] Better indication of what to do with the Metric name #211

eddiebergman commented 10 months ago

You can close an issue automatically using this syntax in github, you don't need to hyperlink it.

* Closes #216

By doing the above, it'll automatically close it once it's merged.

Lastly, can you name the PR's in the same way as the commit messages, i.e. refactor: xyz. This is because when it's merged into main, the PR title will be the commit message

eddiebergman commented 10 months ago

So I pushed some more things. Namely I added error checks to ensure that the metrics are indeed unique (as you specified in the docs) and then also ensure the metric name is a valid python identifier

eddiebergman commented 10 months ago

Can you do another review just to see what's changed?

vladislavalerievich commented 10 months ago

Can you do another review just to see what's changed?

Thank you for adding additional checks.