search

automl / auto-sklearn

Automated Machine Learning with scikit-learn
https://automl.github.io/auto-sklearn
BSD 3-Clause "New" or "Revised" License
7.58k stars 1.28k forks source link

Use `isinstance` instead of `obj.__bases__` in ThirdPartyComponents #1686

Closed AmirAlavi closed 10 months ago

AmirAlavi commented 1 year ago

This is a small change but will enable much easier extending of auto-sklearn algorithms, since without this change, all classes are expected to directly inherit from AutoSklearn base calsses, and do not allow additional layers of inheritance.

Closes #1604

AmirAlavi commented 1 year ago

@eddiebergman this API may be deprecated soon due to the upcoming major refactor, but I have tooling around existing auto-sklearn which this would definitely simplify. I'd appreciate your feedback.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1686 (c97ead6) into development (6732112) will decrease coverage by 0.25%. The diff coverage is 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #1686 +/- ## =============================================== - Coverage 83.45% 83.21% -0.25% =============================================== Files 156 156 Lines 11934 11934 Branches 1900 1900 =============================================== - Hits 9960 9931 -29 - Misses 1409 1435 +26 - Partials 565 568 +3 ``` [![Impacted file tree graph](https://app.codecov.io/gh/automl/auto-sklearn/pull/1686/graphs/tree.svg?width=650&height=150&src=pr&token=5Cs17RkYm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=automl)](https://app.codecov.io/gh/automl/auto-sklearn/pull/1686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=automl)
eddiebergman commented 1 year ago

Hi @AmirAlavi,

Can you take a look at the failing tests? Seems some other changes need to be done as well.

Best, Eddie