search

automl / jahs_bench_201

The first collection of surrogate benchmarks for Joint Architecture and Hyperparameter Search.
https://automl.github.io/jahs_bench_201/
MIT License
13 stars 7 forks source link

Bug in argument check (metrics) #14

Closed PhMueller closed 1 year ago

PhMueller commented 1 year ago

Hi guys,

thanks for the awesome work.

While using it, the line below throws an error, when metrics is specified.

https://github.com/automl/jahs_bench_201/blob/e9a93ade6cd80028b45d46e15de2cd96574a9662/jahs_bench/api.py#L108

I think it should be 

unknown = metrics - set(self.__known_metrics)

instead.

Cheers, Philipp

eddiebergman commented 1 year ago

You're right :) I erroneously made this change before but the merged PR should fix it :)