automl / jahs_bench_201

The first collection of surrogate benchmarks for Joint Architecture and Hyperparameter Search.
https://automl.github.io/jahs_bench_201/
MIT License
13 stars 7 forks source link

Wrong path when loading tabular data #16

Closed PhMueller closed 1 year ago

PhMueller commented 1 year ago

hi guys,

loading the tabular data throws an error.

I think the problem is here:

https://github.com/automl/jahs_bench_201/blob/b9232f301f7fd659a85445bf65d29025ef84ef7d/jahs_bench/api.py#L162-L165

self.data_dir should be self.table_dir:

 def _load_table(self): 
     assert self.table_dir.exists() and self.table_dir.is_dir() 

     table_path = self.table_dir / self.task.value 

Thanks in advance, cheers.

eddiebergman commented 1 year ago

I appreciate all your findings and the solutions :)

PhMueller commented 1 year ago

Wow, that was quick! :-) Thanks a lot for your work!

Sorry for not creating a PR