Fixing RE accuracy evalution

automl / nas_benchmarks

BSD 3-Clause "New" or "Revised" License

91 stars 25 forks source link

Fixing RE accuracy evalution #17

Closed Neeratyoy closed 5 years ago

Neeratyoy commented 5 years ago

Addresses #16.

To Note:

The docstrings still show that the accuracy is the fitness measure used for parent selection (probably as borrowed from the original RE code)
The variable names are still accuracy

Neeratyoy commented 5 years ago

@aaronkl I believe the docstrings remain the same to reflect the original RE code. If you say so, I'll add the relevant comments.

aaronkl commented 5 years ago

I think the docstrings should also be changed to avoid any confusions. Maybe we could add a note to highlight that this is different from the original code.

Neeratyoy commented 5 years ago

Agreed. Since the original code is referenced here, can I then edit away the entire docstring for the Model class to make it relevant?

If not, you can review the PR and merge it.