search

automl / neps

Neural Pipeline Search (NePS): Helps deep learning experts find the best neural pipeline.
https://automl.github.io/neps/
Apache License 2.0
39 stars 11 forks source link

Update pyproject.toml for PyTorch versions #107

Closed Neeratyoy closed 2 weeks ago

Neeratyoy commented 3 weeks ago

@eddiebergman @karibbov are the tests passsing adequate a check for this to be merged?

eddiebergman commented 3 weeks ago

Good enough given what we've got I would say, if it causes issues. Then these issues should have an associated test so we can catch them in the future.

Neeratyoy commented 3 weeks ago

@eddiebergman Do you wanna merge or I go with it?

karibbov commented 3 weeks ago

Updating torch > 2.0.0 requires torchvision >= 0.16. Then, we get an error from import torchvision. Anyone can decrypt the traceback?

karibbov commented 3 weeks ago

Turns out AttributeError: 'int' object has no attribute 'nodes' originates from here. When the dimension of the nested list - graphs is 2 _nested_graphs.ndims sometimes returns 3 if the graphs in the dimension 2 are consistent, which causes the if clause to be taken and graphs list to be corrupted. Made a short fix to it, that doesn't seem to break any tests

Neeratyoy commented 3 weeks ago

That's a great catch!