automotiveMastermind / numonic

The second generation prompt for macOS, Linux, and WSL
MIT License
9 stars 5 forks source link

fix(shell): error installing starship when installing numonic #16

Open patrickserrano opened 2 years ago

patrickserrano commented 2 years ago

Commands to Reproduce

curl --fail --silent --show-error --location https://raw.githubusercontent.com/automotiveMastermind/numonic/main/bootstrap.sh | sh -s

Expected Results

Starship installed, and numonic installation continues

Actual Results

macOS: installing starship...
x Running installation script with non-POSIX `bash` may cause errors.
x Please use `sh` instead.

Any additional logs that will help us?

% curl --fail --silent --show-error --location https://raw.githubusercontent.com/automotiveMastermind/numonic/main/bootstrap.sh | sh -s                 
numonic: establishing sudo (you may be prompted for credentials)...
Password:

numonic: sudo enabled
numonic: creating backup path: /Users/patrickserrano/.local/backup/numonic/2022-32-14-203219
noominic: creating backup from: /Users/patrickserrano/.local/numonic
numonic: backing up bash_completion
numonic: backing up bash_profile
numonic: backing up bashrc
numonic: backing up pam_environment
numonic: backing up profile
numonic: backing up zprofile
numonic: backing up zshrc
numonic: install platform prerequisites for: darwin

##############################################################################
INSTALLING HOMEBREW FOR APPLE SILICON (arm64e)
##############################################################################

##############################################################################
INSTALLING HOMEBREW PACKAGES
##############################################################################

macOS: updating homebrew...
==> Homebrew is run entirely by unpaid volunteers. Please consider donating:
  https://github.com/Homebrew/brew#donations
Updated 1 tap (homebrew/core).
==> Updated Formulae
chezmoi             gnu-getopt          libqalculate        qalculate-gtk
macOS: upgrading git...
To relink, run:
  brew unlink git && brew link git
macOS: upgrading gpg...
To relink, run:
  brew unlink gnupg && brew link gnupg
macOS: upgrading pinentry-mac...
To relink, run:
  brew unlink pinentry-mac && brew link pinentry-mac
macOS: upgrading jq...
To relink, run:
  brew unlink jq && brew link jq
macOS: setting git credential helper to use the macOS keychain...
macOS: installing starship...
x Running installation script with non-POSIX `bash` may cause errors.
x Please use `sh` instead.

Operating System(s)

macOS

Operating System (Other)

No response

Architecture

arm64 / aarch64

Shell

zsh

Terminal Program(s)

apple

Terminal Program(s) (Other)

No response

What is the output from uname -srv on the system(s) where the bug is occurring?

Darwin 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan 5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000

Code of Conduct

patrickserrano commented 2 years ago

Ok so I forked the repo, and updated the install script which let me get numonic installed.

By updating line 110 to pipe the results of the curl call to sh instead of bash everything worked ¯\(ツ)