fix: pushd is not posix compliant

automotiveMastermind / prompt

A spectacular prompt for *nix distributions.

MIT License

9 stars 6 forks source link

fix: pushd is not posix compliant #51

Closed dmccaffery closed 4 years ago

dmccaffery commented 4 years ago

resolve an issue where prompt could fail to install on operating systems where the default shell is not a bash-variant where pushd is available
enable prompt to be installed in WSL 2 (tested in ubuntu) through bootstrap

dmccaffery commented 4 years ago

@sjk07 -- the macos build failed due to a network fluke in circle-ci:

It succeeded otherwise. Up to you if you want to requeue.

sjk07 commented 4 years ago

@dmccaffery the same issue keeps appearing in CI are you sure it's a fluke?

dmccaffery commented 4 years ago

Hmm. Possibly not. I cannot reproduce locally; however. It might be something funky with the circle-ci environment.

dmccaffery commented 4 years ago

Ultimately the part that is breaking was not modified, so I'm not sure what is going on there.

sjk07 commented 4 years ago

also don't see how this would cause the issue, in CI. LGTM

patrickserrano commented 4 years ago

@dmccaffery fwiw, I've been getting the same error locally on macOS:

sjk07 commented 4 years ago

@patrickserrano lets create an issue for this

dmccaffery commented 4 years ago

Interesting @patrickserrano -- one thing that could cause this is if you set a GH_TOKEN or PROMPT_TOKEN env-var in your profile that is not valid. The token is used to authenticate to GitHub APIs to work around possible issues with rate limiting (if you bang GitHub like crazy in day-to-day activities).

dmccaffery commented 4 years ago

env | grep _TOKEN