search

autonity / aut

A command-line RPC client for Autonity
MIT License
11 stars 10 forks source link

Support import and export of account key in encrypted form using Web3 Secret Storage Definition #96

Open cmjc opened 1 year ago

cmjc commented 1 year ago

Context

aut CLI's import account imports an unencrypted private key file. Autonity is better practice to have a private key in the ethereum encryted format ((https://ethereum.org/en/developers/docs/data-structures-and-encoding/web3-secret-storage/))

dtebbs commented 1 year ago

My take on this would be:

  • Should a command or option be added to import an ethereum encrypted keystore file?

No. This is just a matter of copying files. We should not bloat aut with this kind of thing - it should provide a core set of functionality which can be used to build higher level functionality.

  • Should as mirror, a command be added to export an account private key as an ethereum encrypted keystore file?

No. I'm not sure if the autonity or geth binary support this, but I don't think it should be trivial to do and I think it's fine for people to have to jump through hoops to do it. It's a candidate for an external tool or little blog post. Using autonity.py it's probably 3 lines fo python.

cmjc commented 1 year ago

OK. Simple is best.

(It's clear in aut account import-private-key --help it's encrypted format. No, you can't export the key - only list, import, new, update command-line options. Could be a blog post topic, yes.)