search

autonity / aut

A command-line RPC client for Autonity
MIT License
11 stars 10 forks source link

Contract calls #97

Closed dtebbs closed 1 year ago

aiman commented 1 year ago

I am running make check and encountering:

$ make check
mypy -p autcli -p tests
autcli/utils.py:547: error: "Type[ABIManager]" has no attribute "load_abi_file"
autcli/commands/contract.py:48: error: Cannot find implementation or library stub for module named "autonity.abi_parser"
autcli/commands/contract.py:48: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 2 errors in 2 files (checked 21 source files)
make: *** [Makefile:17: check-types] Error 1
aiman commented 1 year ago

Never mind, I switched branches and didn't update submodule :facepalm:

aiman commented 1 year ago

This is really cool.

aiman commented 1 year ago

One thing I wondered about is the type conversion for method parameters from the shell. I can see how the conversion works for almost all Solidity types. The only one I'm not sure about is when structs are passed as parameters. Are there any tests around this?

dtebbs commented 1 year ago

One thing I wondered about is the type conversion for method parameters from the shell. I can see how the conversion works for almost all Solidity types. The only one I'm not sure about is when structs are passed as parameters. Are there any tests around this?

Good question. Unfortunately, structs etc are not yet supported. (https://github.com/autonity/autonity.py/blob/master/autonity/abi_parser.py#L99).

dtebbs commented 1 year ago

Issue in autonity.py regarding the complex input types autonity/autonity.py#18