search

autonome / Dormancy

Firefox add-on that frees inactive tabs from memory, restoring their contents next time you access the tab.
47 stars 14 forks source link

Implement menu and functionality to discard tabs, fixes #11. #33

Open sfleiter opened 5 years ago

sfleiter commented 5 years ago

Merry Christmas!

This pull request adds a tab menu for Dormancy to discard selected, left, right or other tabs. If anything comes up during review please do not hesitate to tell me about it.

sfleiter commented 5 years ago

Any feedback on this @autonome?

sfleiter commented 5 years ago

One question is about the use of "retire". I'm not sure it's the right word here. I've been using asleep/awake, so that there's no worry of tabs actually going away. Even those aren't absolutely consistent with "dormant", but I think they're closer?

I thought a bit more about it and would like to use "put so sleep" throughout according to https://www.merriam-webster.com/dictionary/put%20to%20sleep bullet 3. That would move "do not sleep tabs that play sound" to "do not put tabs to sleep that play sound". I just saw that you used that term already so I assume that should be okay.

Maybe it is time for more consistency and use Dormany only as the extension name and otherwise stay with (put to) sleep and awake or wake up?

sfleiter commented 5 years ago

New version of the code pushed