Closed Keith94 closed 7 years ago
Hmmmm, interesting. I'm not sure I want that in this addon, as it's called always right for a reason ;)
But can you explain the toolbar scenario in a series of steps you're taking? I don't understand it.
Also, I think it's not actually possible until this ships: https://bugzilla.mozilla.org/show_bug.cgi?id=1238314
On Wed, Aug 9, 2017 at 5:19 PM Keith94 notifications@github.com wrote:
I like how this add-on prevent tabs from opening way at the end of the tab bar; but I also wish that the original order of new tabs would be respected too, i.e. new tab 1 should be inserted after current tab, and new tab 2 should be inserted after new tab 1 rather than before it. This is how Firefox normally handles opening new links. Can this be implemented? Most notably opening new bookmarks via toolbar does not use the original order with this add-on installed.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt_2ikEcFGz7x5QjzOQF-COWjjz7Qks5sWXmcgaJpZM4Oxz9p .
Well, for the bookmarks toolbar:
browser.tabs.loadBookmarksInBackground
to true
For me, the order of the tab bar looks like: Original tab | Bookmark 2 | Bookmark 1
But with web page links it seems the results are different? Opening Link 1 and Link 2 will result in the order: Original tab | Link 1 | Link 2
I hope that makes sense. Keeping the original order makes more sense for my workflow, but I didn't find an add-on that can quite do it yet.
Wow, yeah I have no idea how all this would play together with non-default prefs flipped.
The tab order difference you're seeing is likely because "opener" relationship isn't set when opening a bookmark from the toolbar (or anywhere else). That's because there's no relation between the active tab and the bookmarks you're opening - you just happened to have that tab active at the time.
There's a crazy decision-tree that happens when opening new tabs... which is the cause for this extension in the first place: Deterministic. Predictable. No aberration.
Which is why I think what you're asking for should be a different extension altogether.
The code for this extension is pretty simple. Once the opener functionality lands, you could probably copy it and hack a version together that does what you're asking.
On Wed, Aug 9, 2017 at 5:39 PM Keith94 notifications@github.com wrote:
Well, for the bookmarks toolbar:
- Change browser.tabs.loadBookmarksInBackground to true
- Open Bookmark 1 in new tab
- Open Bookmark 2 in new tab
For me, the order of the tab bar looks like: Original tab | Bookmark 2 | Bookmark 1
But with web page links it seems the results are different? Opening Link 1 and Link 2 will result in the order: Original tab | Link 1 | Link 2
I hope that makes sense. Keeping the original order makes more sense for my workflow, but I didn't find an add-on that can quite do it yet.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/11#issuecomment-321206249, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDtzQScBX9YZPqm_6pL6MTSr-Tj_Cnks5sWX44gaJpZM4Oxz9p .
All right, that answers my question. Thanks for reply :)
I like how this add-on prevent tabs from opening way at the end of the tab bar; but I also wish that the original order of new tabs would be respected too, i.e. new tab 1 should be inserted after current tab, and new tab 2 should be inserted after new tab 1 rather than before it. This is how Firefox normally handles opening new links. Can this be implemented? Most notably opening new bookmarks via toolbar does not use the original order with this add-on installed.