autonome / alwaysright

Browser extension that always opens new tabs immediately to the right of the active tab.
https://addons.mozilla.org/en-us/firefox/addon/always-right/
28 stars 5 forks source link

Version 2.0.6 not working on Firefox 55 (64-bit), Linux #14

Closed pviotti closed 6 months ago

pviotti commented 7 years ago

as per title. :(

anyway, thanks for the extension: very useful. (also, wouldn't it make sense to have this as a Firefox setting..?)

pviotti commented 7 years ago

to be precise, it works for links opened in new tabs, but it doesn't work for new empty tabs (Ctrl+t), which are opened at the end of the list of tabs.

autonome commented 7 years ago

Thanks for reporting! I cannot reproduce in Mac or Windows. I'm installing latest Ubuntu in a VM to test there.

On Wed, Aug 30, 2017 at 9:36 PM Paolo notifications@github.com wrote:

to be precise, it works for links opened in new tabs, but it doesn't work for new empty tabs (Ctrl+t), which are opened at the end of the list of tabs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/14#issuecomment-326010764, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt0AVtFBpxzlviKFtDAY76cywqPvpks5sdXOBgaJpZM4PGjkf .

autonome commented 7 years ago

Installed Firefox nightly (57) and cannot reproduce the problem. I'm waiting for Ubuntu updates to see if the version included with Ubuntu updates to 55, but it's taking a while.

On Thu, Aug 31, 2017 at 10:41 PM Dietrich Ayala autonome@gmail.com wrote:

Thanks for reporting! I cannot reproduce in Mac or Windows. I'm installing latest Ubuntu in a VM to test there.

On Wed, Aug 30, 2017 at 9:36 PM Paolo notifications@github.com wrote:

to be precise, it works for links opened in new tabs, but it doesn't work for new empty tabs (Ctrl+t), which are opened at the end of the list of tabs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/14#issuecomment-326010764, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt0AVtFBpxzlviKFtDAY76cywqPvpks5sdXOBgaJpZM4PGjkf .

Nexion commented 7 years ago

@autonome I reported this problem already, on that moment I had firefox 54.0.1. Currently it's 55.0.1 (x64 Linux) and the problem is still here.

The workaround within the browser session is the same: to disable and re-enable the addon again. But even after that sometimes it still can sporadically open tabs at the very end.

grahamperrin commented 7 years ago

Reproducible with 2.0.6 on Firefox 56.0 (64-bit) on FreeBSD with a heavily extended profile:

2017-10-01 14:55:17.mp4.tar.gz

[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% uname -v
FreeBSD 12.0-CURRENT #0 r320869: Mon Jul 10 13:57:55 UTC 2017     root@releng3.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC 
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% pkg info firefox | grep -i version
Version        : 56.0,1
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% 

Not reproducible with a clean profile with Always Right alone.

Remarkable: the new tab appears to be first (1) non-adjacent, then (2) moved to be adjacent.

So maybe in cases where the bug bites, an extension conflict represses step (2).

grahamperrin commented 7 years ago

… maybe … an extension conflict …

That's possible, but essentially I reproduced the issue with:

Two frames from the attached screen recording:

2017-10-01 15 27 39 frame 2017-10-01 15 27 41 frame

2017-10-01 15:26:19.mp4.tar.gz

Not yet consistently reproducible – sorry – but there's an example of the first new tab misplaced (not sliding into place after its first appearance).

autonome commented 7 years ago

It looks like you have tree-style tabs installed, so another tab-related add-on is definitely there in addition to Always Right.

On Wed, Aug 30, 2017 at 2:43 AM Paolo notifications@github.com wrote:

as per title. :(

anyway, thanks for the extension: very useful. (also, wouldn't it make sense to have this as a Firefox setting..?)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt-jdeGJYkho3qRnlTBoq70GK_u8Wks5sdH8LgaJpZM4PGjkf .

grahamperrin commented 7 years ago

… another tab-related add-on is definitely there …

No, definitely not. Please view the screen recording, it's less than three minutes, here's another frame:

2017-10-01 15 26 48 frame

autonome commented 7 years ago

Oops, sorry, I thought the bar on the left was tree-style tabs or something like that 😂

I'm looking through the code to see if there's anything where we might have a race, or some invalid activeTab value that could cause this.

grahamperrin commented 7 years ago

:-)

Maybe worth mentioning: whilst there's no Tab Groups installation in the profile that I used to demonstrate the issue, the session file for the demo did originate from an everyday profile where I make extensive use of Tab Groups.

autonome commented 6 months ago

The underlying Firefox code and APIs are all different now, and the extension has been updated to manifest v3 so all the code from this period is likely entirely different. We can reopen if you're still having issues.