search

autonome / alwaysright

Browser extension that always opens new tabs immediately to the right of the active tab.
https://addons.mozilla.org/en-us/firefox/addon/always-right/
28 stars 5 forks source link

Always Right is not a multi-process compatible extension #6

Closed cpeterso closed 7 years ago

cpeterso commented 7 years ago

Firefox will soon only support multi-process compatible extensions and Always Right is not one. To test, set the extensions.allow-non-mpc-extensions pref to false. The Add-ons Manager will disable the extension and show the warning: "alwaysright has been disabled since it is not multiprocess compatible."

For more information about this warning, see https://wiki.mozilla.org/Add-ons/ShimsNightly.

blissdev commented 7 years ago

Do we know what it would take to be multiprocess compatible? I'm not sure how deep of a change it is, would it require essentially starting from scratch?

autonome commented 7 years ago

Yeah it's basically starting from scratch. I ported to WebExtension a while back. This add-on is quite simple, so it's only a few lines of code. However, I experienced weird issues. I'll try to have another look.

On Thu, May 4, 2017 at 11:28 PM Jordan Arentsen notifications@github.com wrote:

Do we know what it would take to multiprocess compatible? I'm not sure how deep of a change it is, would it require essentially starting from scratch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/6#issuecomment-299220632, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt500h6RTCgjpVBqP4PrmSdT6A6edks5r2e6SgaJpZM4NJ2i_ .

autonome commented 7 years ago

Oh the code is in this branch: https://github.com/autonome/Always-Right/tree/webextension

On Thu, May 4, 2017 at 11:31 PM Dietrich Ayala autonome@gmail.com wrote:

Yeah it's basically starting from scratch. I ported to WebExtension a while back. This add-on is quite simple, so it's only a few lines of code. However, I experienced weird issues. I'll try to have another look.

On Thu, May 4, 2017 at 11:28 PM Jordan Arentsen notifications@github.com wrote:

Do we know what it would take to multiprocess compatible? I'm not sure how deep of a change it is, would it require essentially starting from scratch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/6#issuecomment-299220632, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt500h6RTCgjpVBqP4PrmSdT6A6edks5r2e6SgaJpZM4NJ2i_ .

blissdev commented 7 years ago

@autonome What weird issues did you experience?

autonome commented 7 years ago

I can't remember exactly offhand. Will try again soon. On Thu, May 4, 2017 at 23:36 Jordan Arentsen notifications@github.com wrote:

@autonome https://github.com/autonome What weird issues did you experience?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/6#issuecomment-299223075, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt8ifvZdhfsgqtYRWOZBDkEY4CyUsks5r2fCFgaJpZM4NJ2i_ .

autonome commented 7 years ago

Tested against release Firefox, seemed to work ok, so bundled and submitted for review.

https://addons.mozilla.org/en-US/developers/addon/always-right/versions/2094103

On Thu, May 4, 2017 at 11:41 PM Dietrich Ayala autonome@gmail.com wrote:

I can't remember exactly offhand. Will try again soon. On Thu, May 4, 2017 at 23:36 Jordan Arentsen notifications@github.com wrote:

@autonome https://github.com/autonome What weird issues did you experience?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/autonome/Always-Right/issues/6#issuecomment-299223075, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt8ifvZdhfsgqtYRWOZBDkEY4CyUsks5r2fCFgaJpZM4NJ2i_ .

autonome commented 7 years ago

Pushed to AMO a few days ago, so closing this.

No victory though... the WebExtension is broken in a bunch of ways. I recommend reverting to the older version for now.