search

autonome / puppeteer-fx

Minimal implementation of the Puppeteer API for Firefox.
MIT License
31 stars 3 forks source link

[ Refactor ] Make this project more engineering #1

Closed TechQuery closed 6 years ago

TechQuery commented 6 years ago

Split Core Classes (Puppeteer, Browser & Page) into Independent Source-code Files, and add Engineering Configuration & API documentation files.

autonome commented 6 years ago

This is fantastic, thanks so much! You have vastly improved my original code. I'm going to merge this now.

However, before releasing new version on NPM I do want to write a test, and ensure it works against my existing scripts. If there are issues, we can fix here in the new code.

TechQuery commented 6 years ago

Oh, thanks so much!

https://github.com/TechQuery/Puppeteer-IE/tree/master/test may be help to you.

And I'm going to write more features & tests after the merge.

autonome commented 6 years ago

πŸ‘πŸΌπŸ‘πŸΌπŸ‘πŸΌ Thanks, I'll start with that!

On Thu, Apr 19, 2018 at 5:10 PM 南漂一卒 notifications@github.com wrote:

Oh, thanks so much! And https://github.com/TechQuery/Puppeteer-IE/tree/master/test may be help

β€” You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/autonome/puppeteer-fx/pull/1#issuecomment-382920200, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt26VaCVQbhprwnIG-nWNS5d31IlWks5tqSd-gaJpZM4TJFzF .

TechQuery commented 6 years ago

You can host /docs folder by GitHub Pages to show JS API document online.