Closed AntoineTurmel closed 6 years ago
Not sure what you mean? Allow them to use notifications?
On Thu, Aug 13, 2015 at 10:46 AM Antoine Turmel notifications@github.com wrote:
Sites like Skype or Wunderlist uses notifications, it would be great to add them in the manifest ;)
— Reply to this email directly or view it on GitHub https://github.com/autonome/standalone/issues/3.
Yes. In terms of UI it could be a popup allowing the user to set permissions of the Standalone app.
Hm, yeah that's going to take some doing. I wonder what Firefox permissions do when user is fullscreen, and if that might happen here already.
I don't have time right now to do this, but you could test by requesting notification permissions from a page, and making it an app with Standalone, and see what happens?
On Thu, Aug 13, 2015 at 11:45 AM Antoine Turmel notifications@github.com wrote:
Yes. In terms of UI it could be a popup allowing the user to set permissions of the Standalone app.
— Reply to this email directly or view it on GitHub https://github.com/autonome/standalone/issues/3#issuecomment-130798322.
It's not working, but I might just contribute to Standalone ;)
I've the same issue here with whatsapp webapp. no time to enable the notification, the popup disappear very fast.
If y'all want to investigate, I'm glad to review your changes and add this feature! I just don't have time to work on it right now.
On Thu, Aug 13, 2015 at 11:27 AM Dietrich Ayala autonome@gmail.com wrote:
Not sure what you mean? Allow them to use notifications?
On Thu, Aug 13, 2015 at 10:46 AM Antoine Turmel notifications@github.com wrote:
Sites like Skype or Wunderlist uses notifications, it would be great to add them in the manifest ;)
— Reply to this email directly or view it on GitHub https://github.com/autonome/standalone/issues/3.
@filipesizilio try my version if you want: https://github.com/AntoineTurmel/standalone/releases
@AntoineTurmel ok, I'm already testing. thank you.
Hi @AntoineTurmel, until now, works fine on ubuntu 15.04 and firefox 40.0.3. Congratulations.
Awesome, send a PR :D
On Mon, Sep 7, 2015 at 2:21 AM Antoine Turmel notifications@github.com wrote:
@filipesizilio https://github.com/filipesizilio try my version if you want: https://github.com/AntoineTurmel/standalone/releases
— Reply to this email directly or view it on GitHub https://github.com/autonome/standalone/issues/3#issuecomment-138248290.
@autonome yeah but I have to work a bit more on this, as this commit allow notifications for every website, IMHO we should ask the user before (like Firefox Desktop/Firefox OS/Android does)
ah yeah, good for prototype but maybe not for release.
I wonder what the doorhanger prompt does when there's no XUL window...
On Tue, Sep 8, 2015 at 1:24 PM Antoine Turmel notifications@github.com wrote:
@autonome https://github.com/autonome yeah but I have to work a bit more on this, as this commit allow notifications for every website, IMHO we should ask the user before (like Firefox Desktop/Firefox OS/Android does)
— Reply to this email directly or view it on GitHub https://github.com/autonome/standalone/issues/3#issuecomment-138689182.
Is the prompt really needed, since one already approves the webapp to some extent by promoting it to a desktop app. Having them enabled now and adding an improved version later is imho better than not having them at all :-) Thanks for making them work in the first place!
I agree that we should allow notifications by default, instead of forcing explicit user approval like a web site.
Apps can provide their own notification management in user preferences... like native desktop apps do!
Sites like Skype or Wunderlist uses notifications, it would be great to add them in the manifest ;)