Closed mikkokotila closed 5 years ago
Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
talos/__init__.py
:Line 17:80: E501 line too long (80 > 79 characters)
talos/commands/kerasmodel.py
:Line 11:80: E501 line too long (83 > 79 characters)
talos/commands/params.py
:Line 104:80: E501 line too long (84 > 79 characters)
talos/examples/datasets.py
:Line 4:80: E501 line too long (92 > 79 characters) Line 18:80: E501 line too long (92 > 79 characters) Line 42:80: E501 line too long (92 > 79 characters) Line 59:80: E501 line too long (92 > 79 characters) Line 77:80: E501 line too long (92 > 79 characters)
talos/examples/models.py
:Line 10:80: E501 line too long (83 > 79 characters) Line 52:80: E501 line too long (83 > 79 characters)
talos/reducers/permutation_filter.py
:Line 20:80: E501 line too long (98 > 79 characters)
talos/reducers/sample_reducer.py
:Line 60:80: E501 line too long (86 > 79 characters)
talos/utils/string_cols_to_numeric.py
:Line 27:13: E722 do not use bare 'except' Line 30:17: E722 do not use bare 'except'
test/core_tests/test_scan.py
:Line 46:80: E501 line too long (80 > 79 characters) Line 92:9: E117 over-indented Line 135:80: E501 line too long (80 > 79 characters) Line 178:80: E501 line too long (87 > 79 characters) Line 199:80: E501 line too long (80 > 79 characters) Line 222:80: E501 line too long (85 > 79 characters)
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
talos/init.py | 17 | 18 | 94.44% | ||
talos/metrics/keras_metrics.py | 4 | 5 | 80.0% | ||
talos/parameters/ParamGrid.py | 24 | 25 | 96.0% | ||
talos/scan/scan_finish.py | 2 | 3 | 66.67% | ||
talos/utils/generator.py | 0 | 1 | 0.0% | ||
talos/commands/params.py | 77 | 79 | 97.47% | ||
talos/scan/scan_prepare.py | 5 | 7 | 71.43% | ||
talos/utils/init.py | 8 | 10 | 80.0% | ||
talos/utils/string_cols_to_numeric.py | 3 | 5 | 60.0% | ||
talos/scan/scan_run.py | 2 | 5 | 40.0% | ||
<!-- | Total: | 292 | 325 | 89.85% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
talos/metrics/keras_metrics.py | 1 | 90.24% | ||
talos/utils/gpu_utils.py | 2 | 50.0% | ||
talos/reducers/sample_reducer.py | 2 | 70.97% | ||
talos/parameters/round_params.py | 2 | 88.24% | ||
<!-- | Total: | 7 | --> |
Totals | |
---|---|
Change from base Build 444: | -0.8% |
Covered Lines: | 1123 |
Relevant Lines: | 1247 |
NOTE: this is the actual v.0.5 to Master merge.