Update to layers.py - Githubissues

autonomio / talos

Hyperparameter Experiments with TensorFlow and Keras

https://autonom.io

MIT License

1.62k stars 268 forks source link

Update to layers.py #291

Closed chris8447 closed 5 years ago

chris8447 commented 5 years ago

make sure that all tests are passed - DONE!
create some unit tests and update testing procedures accordingly - DONE!
make PR to dev (or daily-dev) - OK!

I had the problem myself whenever I included the value zero in the hidden_layers param and I got an error. Here's a fix for it showing the user that she/he has to remove the value.

pep8speaks commented 5 years ago

Hello @chris8447! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/model/layers.py:

Line 66:80: E501 line too long (88 > 79 characters) Line 67:80: E501 line too long (83 > 79 characters) Line 69:80: E501 line too long (119 > 79 characters) Line 70:1: W293 blank line contains whitespace

chris8447 commented 5 years ago

@mikkokotila It's my first PR. Is it correct? :)

mikkokotila commented 5 years ago

Actually, there is no issue here. You can try:

for i in range(0):
    print("hello")

...and nothing will be printed. If there was, it would follow that 1 would print 2 "hello", 2 would print 3 "hello" and so on.