Fix of parameter space - Githubissues

autonomio / talos

Hyperparameter Experiments with TensorFlow and Keras

https://autonom.io

MIT License

1.62k stars 268 forks source link

Fix of parameter space #325

Closed andrewtavis closed 5 years ago

andrewtavis commented 5 years ago

Shouldn't there be brackets in the parameter space for dropout and the learning rate? In my runs it's just selecting the first value. Also put some values in that seemed more reasonable.

It actually does some pretty weird things if you put parentheses in for some of the other parameter options as well. first_neuron and batch_size will run the space for more options than would be in the multiplicative space. In the others I checked it thankfully throws an error though.

Thanks for this!

make sure that all tests are passed
create some unit tests and update testing procedures accordingly
make PR to dev (or daily-dev)

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 484

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 90.056%

Totals
Change from base Build 448:	0.08%
Covered Lines:	1123
Relevant Lines:	1247

💛 - Coveralls

mikkokotila commented 5 years ago

[] is for a list of discrete values, and () is for a range of values.

andrewtavis commented 5 years ago

Apologies for not reading the documentation thoroughly.