Closed mikkokotila closed 5 years ago
Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
talos/__init__.py
:Line 6:1: E402 module level import not at top of file Line 7:1: E402 module level import not at top of file Line 15:1: E402 module level import not at top of file Line 16:1: E402 module level import not at top of file
talos/autom8/automodel.py
:Line 122:80: E501 line too long (80 > 79 characters)
talos/autom8/autoparams.py
:Line 202:80: E501 line too long (81 > 79 characters)
talos/autom8/autopredict.py
:Line 1:1: E302 expected 2 blank lines, found 0 Line 100:80: E501 line too long (84 > 79 characters) Line 103:80: E501 line too long (82 > 79 characters)
talos/commands/analyze.py
:Line 77:9: E722 do not use bare 'except' Line 183:80: E501 line too long (81 > 79 characters) Line 205:80: E501 line too long (80 > 79 characters) Line 220:80: E501 line too long (82 > 79 characters)
talos/logging/logging_run.py
:Line 21:80: E501 line too long (83 > 79 characters)
talos/metrics/entropy.py
:Line 30:80: E501 line too long (85 > 79 characters)
talos/model/early_stopper.py
:Line 16:80: E501 line too long (83 > 79 characters)
talos/reducers/GamifyMap.py
:Line 41:80: E501 line too long (86 > 79 characters)
talos/reducers/reduce_run.py
:Line 35:19: E712 comparison to True should be 'if cond is True:' or 'if cond:'
talos/reducers/reduce_utils.py
:Line 29:80: E501 line too long (87 > 79 characters)
talos/scan/scan_addon.py
:Line 53:80: E501 line too long (80 > 79 characters)
talos/scan/scan_round.py
:talos/templates/datasets.py
:Line 21:80: E501 line too long (127 > 79 characters) Line 45:80: E501 line too long (92 > 79 characters) Line 59:80: E501 line too long (92 > 79 characters) Line 84:80: E501 line too long (92 > 79 characters) Line 101:80: E501 line too long (92 > 79 characters) Line 119:80: E501 line too long (92 > 79 characters)
talos/templates/models.py
:Line 7:80: E501 line too long (80 > 79 characters) Line 48:80: E501 line too long (80 > 79 characters)
test/commands/test_latest.py
:Line 36:80: E501 line too long (96 > 79 characters)
test/commands/test_scan.py
:Line 66:80: E501 line too long (97 > 79 characters) Line 151:5: E303 too many blank lines (2)
test/performance/memory_pressure.py
:Line 11:18: E231 missing whitespace after ':' Line 20:1: E302 expected 2 blank lines, found 1 Line 26:80: E501 line too long (107 > 79 characters) Line 38:80: E501 line too long (85 > 79 characters) Line 39:53: E127 continuation line over-indented for visual indent Line 40:53: E127 continuation line over-indented for visual indent Line 40:80: E501 line too long (83 > 79 characters) Line 41:53: E127 continuation line over-indented for visual indent Line 42:53: E127 continuation line over-indented for visual indent Line 43:53: E127 continuation line over-indented for visual indent Line 54:1: E101 indentation contains mixed spaces and tabs Line 54:1: W191 indentation contains tabs Line 54:21: E128 continuation line under-indented for visual indent Line 59:1: E101 indentation contains mixed spaces and tabs
test/performance/memory_pressure_check.py
:Line 23:80: E501 line too long (137 > 79 characters) Line 26:80: E501 line too long (118 > 79 characters)
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
talos/model/early_stopper.py | 2 | 3 | 66.67% | ||
talos/reducers/limit_by_metric.py | 7 | 8 | 87.5% | ||
talos/reducers/sample_reducer.py | 9 | 10 | 90.0% | ||
talos/commands/evaluate.py | 15 | 17 | 88.24% | ||
talos/logging/results.py | 18 | 20 | 90.0% | ||
talos/scan/scan_finish.py | 13 | 15 | 86.67% | ||
talos/utils/experiment_log_callback.py | 40 | 42 | 95.24% | ||
talos/utils/torch_history.py | 3 | 5 | 60.0% | ||
talos/metrics/entropy.py | 15 | 18 | 83.33% | ||
talos/commands/deploy.py | 9 | 13 | 69.23% | ||
<!-- | Total: | 839 | 1007 | 83.32% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
talos/commands/evaluate.py | 1 | 91.43% | ||
talos/reducers/correlation.py | 1 | 94.12% | ||
talos/reducers/sample_reducer.py | 1 | 69.7% | ||
talos/model/normalizers.py | 2 | 83.33% | ||
talos/utils/connection_check.py | 5 | 0.0% | ||
talos/commands/predict.py | 10 | 21.05% | ||
<!-- | Total: | 20 | --> |
Totals | |
---|---|
Change from base Build 509: | -4.5% |
Covered Lines: | 1306 |
Relevant Lines: | 1527 |
You want to make a PR to Talos
Thanks so much :) First, please take a moment to carefully check through the below items: