v0.6.4 to Dev - Githubissues

autonomio / talos

Hyperparameter Experiments with TensorFlow and Keras

https://autonom.io

MIT License

1.62k stars 270 forks source link

v0.6.4 to Dev #392

Closed mikkokotila closed 4 years ago

mikkokotila commented 4 years ago

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through the below items:

[x] Changes have gone through actual use testing
[x] Docs are updated where relevant
[x] Code is PEP8
[x] All local tests have passed (run ./test.sh in /talos)
[x] Travis tests have passed
[x] Open a pull request
[ ] PR is to daily-dev branch

pep8speaks commented 4 years ago

Hello @mikkokotila! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/model/normalizers.py:

Line 27:80: E501 line too long (84 > 79 characters)

Comment last updated at 2019-09-03 11:48:26 UTC

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 583

12 of 13 (92.31%) changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 85.609%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
talos/model/hidden_layers.py	7	8	87.5%
<!--	Total:	12	13	92.31%	-->

Files with Coverage Reduction	New Missed Lines	%
talos/model/network_shape.py	1	96.43%
<!--	Total:	1		-->

Totals
Change from base Build 577:	-0.1%
Covered Lines:	1279
Relevant Lines:	1494

💛 - Coveralls