Open rlleshi opened 3 years ago
Welcome to Talos community! Thanks so much for creating your first issue :)
I think best make it into a dictionary. The goal here is to be able to feed back to the experiment programmatically.
I second this. I have no idea how to read my best_params output. Documentation also needs to be added for the parameters of best_params(). exclude is required, but I don't know what it is.
Currently
Reporting.best_params
will return an array containing the best parameter values. However, it will not return the corresponding parameter names and this makes it difficult to tell apart which value stands for which parameter.1) I think Talos should add
In commands/analyze.py, I think it would be better if
best_params
returned the complete dataframe (out
) instead of the values (out.values
)2) Once implemented, I can see how this feature will
It will be easier to understand which values correspond to which parameters
3) I believe this feature is
nice to have
4) Given the chance, I'd be happy to make a PR for this feature
definitely