Fix param index - Githubissues

autonomio / talos

Hyperparameter Experiments with TensorFlow and Keras

https://autonom.io

MIT License

1.62k stars 268 forks source link

Fix param index #583

Closed mikkokotila closed 2 years ago

mikkokotila commented 2 years ago

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through the below items:

Sanity

[x] I'm aware of the implications of the proposed changes
[x] Code is PEP8
[x] I'm making the PR to master
[x] I've changed the version in setup.py based on Semantic Versioning

Docs

[x] Docs are updated
[x] Docs version is correct on (index.html and _coverpage.md)

Tests

[x] Changes have gone through actual use testing
[x] All local tests have passed (run ./test.sh in /talos)
[x] Tests have been updated to reflect the changes

Fixes #512

pep8speaks commented 2 years ago

Hello @mikkokotila! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/parameters/ParamSpace.py:

Line 135:17: E741 ambiguous variable name 'l'

Comment last updated at 2022-04-15 09:52:23 UTC