Make callbacks to a submodule - Githubissues

autonomio / talos

Hyperparameter Experiments with TensorFlow and Keras

https://autonom.io

MIT License

1.62k stars 270 forks source link

Make callbacks to a submodule #586

Closed mikkokotila closed 2 years ago

mikkokotila commented 2 years ago

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through the below items:

Sanity

[x] I'm aware of the implications of the proposed changes
[x] Code is PEP8
[x] I'm making the PR to master
[x] I've updated the versions based on Semantic Versioning
- [x] setup.py
- [x] talos/__init__.py
- [x] docs/index.html
- [x] docs/_coverpage.md

Docs

[x] Docs are updated

Tests

[ ] Changes have gone through actual use testing
[x] All local tests have passed (run ./test.sh in /talos)
[x] Tests have been updated to reflect the changes

pep8speaks commented 2 years ago

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file talos/__init__.py:

Line 17:1: E402 module level import not at top of file

In the file tests/commands/test_latest.py:

Line 46:80: E501 line too long (89 > 79 characters)