Open joshfriend opened 1 year ago
I checked out the indicated commit and ran projectHealth locally and get that same error that CI apparently reported:
$ git checkout e917cfb80c61bde10f93713a095b24e09f5fb8c4
$ ./gradlew :common:bill-pay:payment-methods:impl:projectHealth
> Task :common:bill-pay:payment-methods:impl:projectHealth FAILED
* What went wrong:
Execution failed for task ':common:bill-pay:payment-methods:impl:projectHealth'.
> These transitive dependencies should be declared directly:
implementation deps.uisys.utils
and when I run reason
, I get this output
> Task :common:bill-pay:payment-methods:impl:reason
----------------------------------------
You asked about the dependency 'com.squareup.ui.utils:uisys-android-utils:9.6.0 (deps.uisys.utils)'.
You have been advised to add this dependency to 'implementation'.
----------------------------------------
Shortest path from :common:bill-pay:payment-methods:impl to com.squareup.ui.utils:uisys-android-utils:9.6.0 (deps.uisys.utils) for debugCompileClasspath:E
:common:bill-pay:payment-methods:impl
\--- register.common.container-inversion:public
\--- register.uisys.components-mosaic:public
\--- com.squareup.ui.utils:uisys-android-utils:9.6.0
Shortest path from :common:bill-pay:payment-methods:impl to com.squareup.ui.utils:uisys-android-utils:9.6.0 (deps.uisys.utils) for debugRuntimeClasspath:
:common:bill-pay:payment-methods:impl
\--- com.squareup.ui.market:uisys-android-market-components:9.6.0
\--- com.squareup.ui.utils:uisys-android-utils:9.6.0
Source: debug, main
-------------------
* Uses 1 resource: AttrRef(type=attr, id=sqBoldWeight) (implies implementation).
Currently cannot reproduce.
Build scan link
Plugin version 1.25.0
Gradle version 8.3
JDK version 17
(Optional) Kotlin and Kotlin Gradle Plugin (KGP) version Kotlin 1.9.10
(Optional) Android Gradle Plugin (AGP) version AGP 8.1.1
(Optional)
reason
output for bugs relating to incorrect adviceDescribe the bug DAGP in CI flags a dependency as unused when running
buildHealth
on the set ofcommon
projects:Running
projectHealth
locally on this same commit returns no issue.When I add the requested dependency requested by the CI failure,
buildHealth
returns:I ran
projectHealth
locally and it reports the same conclusion.To Reproduce Steps to reproduce the behavior:
e917cfb80c61bde10f93713a095b24e09f5fb8c4
of the relevant repo./gradlew -p common/bill-pay/payment-methods/impl projectHealth
. It does not report the same result asbuildHealth
run in CI (see above)Expected behavior One and only one of the above suggestions should is correct and DAGP should provide that one, not both 😄