search

autonomousapps / dependency-analysis-gradle-plugin

Gradle plugin for JVM projects written in Java, Kotlin, Groovy, or Scala; and Android projects written in Java or Kotlin. Provides advice for managing dependencies and other applied plugins
Apache License 2.0
1.67k stars 115 forks source link

fix: make file relativizing work properly on Windows #1140

Closed Vampire closed 4 months ago

Vampire commented 4 months ago

The file relativizing only worked properly on *nix systems. On Windows even executing the tests failed with the code before this PR. The PR makes the method work consistently on all operating systems.

autonomousapps commented 4 months ago

Thanks for the PR. Out of curiosity, how exactly do the tests fail on Windows currently? Do you have a build scan?

Vampire commented 4 months ago

Sure: https://scans.gradle.com/s/armb2gse65nk6/tests/task/:test/details/com.autonomousapps.internal.utils.FilesTest?top-execution=1

autonomousapps commented 4 months ago

scans.gradle.com/s/armb2gse65nk6/tests/task/:test/details/com.autonomousapps.internal.utils.FilesTest?top-execution=1

Haha, that's straightforward enough.