search

autonomoussoftware / metronome

Metronome autonomous system
MIT License
14 stars 10 forks source link

FixedMath operations with small numbers return unexpectedresults #14

Closed filcap closed 6 years ago

filcap commented 6 years ago

Risk: Medium Impact: Medium Likelihood: Low

Refer to Coinspect Audit Report Issue MTN-002

filcap commented 6 years ago

@patidarmanoj10 lets consider adding some assertions to validate range of inputs (i.e., throw if amounts too small for the 18 decimal math). Also include tests for these cases.

filcap commented 6 years ago

@rokso confirmed that FixedMath functions should only be internal available to Formula contract.