search

autonomoussoftware / metronome

Metronome autonomous system
MIT License
14 stars 10 forks source link

Use “emit” keyword to raise Events #18

Closed filcap closed 6 years ago

filcap commented 6 years ago

Risk: Medium Impact: High Likelihood: Low

Refer to Coinspect Audit Report Issue MTN-006

filcap commented 6 years ago

@patidarmanoj10 related to issue #16. If we consider using pragma 0.4.21, we can add the emit keywords to the contract.

patidarmanoj10 commented 6 years ago

Emit keyword is added in compiler version 0.4.21 . As of now we can not upgrade to this version for following reasons. 1) Truffle has not released its new version with solc version 0.4.21 2) solhint will also give error with emit keywords as of now hence all pre-commit checks will fail. This too will need updated version of solhint plugin.

filcap commented 6 years ago

no action required.