search

autonomoussoftware / metronome

Metronome autonomous system
MIT License
14 stars 10 forks source link

Floor price in daily auctions #52

Closed rokso closed 6 years ago

rokso commented 6 years ago
  1. Changed floor price in dailyAuction to be 1 wei, issue #25
  2. Fixed Low Severity issue, Formula priceAtInitialAuction may return zero (pg 12). issue #40
  3. Updated tests
rokso commented 6 years ago

@filcap @patidarmanoj10 please review this PR

patidarmanoj10 commented 6 years ago

@rokso One test is failing so lets hold this PR. @filcap FYI. Please do not merge.

filcap commented 6 years ago

@rokso looks like it may be just a rounding issue in the unit test.

rokso commented 6 years ago

@patidarmanoj10 @filcap as fil said it was rounding issue. Now we have a floor price of 1 wei, due to this calculations going too low and causing rounding issue and we had high floor price before and that is why we didn't see it in this test case. I did fix the test, also optimized the test by using our shared test util.