Typescript bindings - Githubissues

autonomoussoftware / metronome

Metronome autonomous system

MIT License

14 stars 10 forks source link

Typescript bindings #75

Closed euforic closed 4 years ago

euforic commented 5 years ago

Add typescript contract binding generation
Update package.json with generation script
Update package.json to use local bins to ensure consistent versions
Add .eslintignore to ignore generated typescript code
Bump Node.js / NPM version
Update travis Node.js version

This one might not be as needed, but I figured it would be nice to have an official js API binding too

Note Please merge #74 -> #73 and then this PR

jcvernaleo commented 5 years ago

Big +1 on making sure you use local bins in package.json. I have no opinion on the typescript stuff itself.

Not sure about bumping the allowed nodejs version. @gabmontes should probably comment on that.

euforic commented 5 years ago

@jcvernaleo yeah in order to get the typescript bindings to generate I had to bump the version of node. You can diff the compile with the two different versions of node I'm pretty sure they are identical.

jcvernaleo commented 5 years ago

It occurs to me that if you need a newer nodejs maybe it should also be updated in the .travis.yml as well.

euforic commented 5 years ago

@jcvernaleo updated travis and commit notes