search

autonomoussoftware / metronome

Metronome autonomous system
MIT License
14 stars 10 forks source link

Ticker search-and-replace #9

Closed jgarzik closed 6 years ago

jgarzik commented 6 years ago

When ticker is assigned, we must change all symbols with 'MTN' string.

Alternately, we can remove the ticker from strings whereever possible.

twleung commented 6 years ago

I think we should remove MTN prefixes from names.   Usually we have a string with the token symbol, which should also get set appropriately.

On Mar 8, 2018, 12:11 PM -0800, Jeff Garzik notifications@github.com, wrote:

When ticker is assigned, we must change all symbols with 'MTN' string. Alternately, we can remove the ticker from strings whereever possible. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- This message and its contents are proprietary and confidential and only for its intended recipient. If you received this message in error, do not use, forward, copy or rely on it. Instead please notify the sender and then delete this message and its attachments, if any. Thank you.

filcap commented 6 years ago

I have already changed the symbol from "MTN" to "MET". I believe that is the only thing that gets noticed by exchanges. We can also refactor any contract variables and function names to also reflect, but that would be more for stylistic preference and consistency.

filcap commented 6 years ago

https://github.com/autonomoussoftware/metronome/blob/master/contracts/monolithic.sol#L576

jgarzik commented 6 years ago

@filcap Mostly agree - it's a bit more than just consistency - we are going through the process of making sure the O.M. API docs are up to date, and there are public functions and symbols containing the older ticker 'MTN' string. This has already raised questions internally, resulting in this issue :)

It is certainly a 100% cosmetic change, not a functional change, but it is ABI-visible and needs cleanup before launch.

My recommendation is simply to remove the 'MTN' substring from variable and function names, and not search-and-replace the substring with the new ticker, but I leave that final stylistic choice up to you & the folks.

filcap commented 6 years ago

We'll submit a PR, @patidarmanoj10 , is working on this

patidarmanoj10 commented 6 years ago

@filcap , @jgarzik I have sent PR for this item.

filcap commented 6 years ago

PR #20 has been merged.