search

autonomousvision / convolutional_occupancy_networks

[ECCV'20] Convolutional Occupancy Networks
https://pengsongyou.github.io/conv_onet
MIT License
830 stars 113 forks source link

Bug in generating walls for synthetic dataset? #47

Closed ZhaoyangZh closed 2 years ago

ZhaoyangZh commented 2 years ago

https://github.com/autonomousvision/convolutional_occupancy_networks/blob/f15b97da2c5995598537c8f832e52e95c0b09236/scripts/dataset_synthetic_room/build_dataset.py#L352

I think it should be if walls[3] == 1. Is it a typo?

m-niemeyer commented 2 years ago

Yes, you are right, thanks for spotting this!

pengsongyou commented 2 years ago

@ZhaoyangZh Thanks for pointing it out! We have updated the code accordingly: https://github.com/autonomousvision/convolutional_occupancy_networks/commit/c30692534d5e02d53c1fa34bd2696bd629d12632

Best Songyou

ZhaoyangZh commented 2 years ago

My pleasure.