Closed mworchel closed 4 years ago
Hey mworchel, that's great - thanks a lot for doing this. I don't have access to a Windows machine, but I assume you tested it so I will go ahead and merge your changes Thanks again for this contribution!
Yes, I successfully tested it on two Windows machines.
Thanks for the merge!
That's great, thanks a lot again for your great work!
Hi,
this PR fixes several issues (such as #15) when trying to run the code using a Windows machine. I tried to be as clear as possible with the commit messages but if something does not immediately make sense, don't hesitate to ask. The large diff in the main scripts is not as large as it seems (and more obvious if you disable whitespace comparisons). Essentially, I just wrapped the scripts in a
Otherwise, they will not run due to the way the
multiprocessing
lib is implemented under Windows (see https://stackoverflow.com/a/18205006)The cause for the error in #15 seems to be that the type
np.int64
corresponds tolong long
under Windows and notlong
as assumed by the code. I fixed it by using Cython's typecnp.int64_t
instead oflong
, which should be resolved to the right type, independent of the platform.