search

autonomousvision / factor-fields

[SIGGRAPH 2023] We provide a unified formula for neural fields (Factor Fields) and a novel dictionary factorization (Dictionary Fields)
https://apchenstu.github.io/FactorFields/
MIT License
201 stars 10 forks source link

args is not defined in train_across_scene.py #8

Open onpix opened 1 year ago

onpix commented 1 year ago

as titled, train_across_scene.py:L212 is:

if args.render_train:
    ...

But args is not defined.

apchenstu commented 1 year ago

Ah, thank you! Yeah, it should be "cfg. render_train:", will fix it

onpix commented 1 year ago

Thanks for your response. But it seems that the L215 has an error as well: 

PSNRs_test = evaluation(train_dataset,model, args, renderer, f'{logfolder}/imgs_train_all/',
                                N_vis=-1, N_samples=-1, white_bg = white_bg, ndc_ray=ndc_ray,device=device)

I guess args should not be here, and renderer is also not defined._

apchenstu commented 1 year ago

Ah okay, thanks!